On Sat, Jul 31, 2010 at 04:37:37PM -0700, Bernard Li wrote:
> if it looks good I'll check it into trunk:
looks good, but haven't test it (don't have MacOS X anyway), with only the
following comments :
* probably better (as it will make for a faster configure) to have all
AC_CHECK_HEADERS checks eventually together in one single macro instead
of spread around.
* eventually (assuming they are make to work again) same changes should
be applied to xdr{client,server} in tests.
also (since it is related to the rpc support anyway), wouldn't anyone have
any objection on committing a "fixed" generated gm_protocol.h (and friends)
instead of relying on the local rpcgen to generate them at build time?
advantages will be that all hacks around at least cygwin's implementation
of it will be removed and all dependencies to rpc/rpc.h will be truly
dropped, but of course, the disadvantage would be (mostly philosofical)
that an intermediate file would had been already propagated into each supported
platform and so it would need to be tested to be valid and work correctly
in all of them without having to rely on local platform knowledge.
anyone patching gm_protocol.x could just regenerate it anyway, as far as
the makefile rule is left there (which then could be a problem for some
as well, if they have a clock skew problem that confuses make and forces
recreating those files for no reason) and so customizations shouldn't
be a concern AFAIK.
Carlo
------------------------------------------------------------------------------
The Palm PDK Hot Apps Program offers developers who use the
Plug-In Development Kit to bring their C/C++ apps to Palm for a share
of $1 Million in cash or HP Products. Visit us here for more details:
http://p.sf.net/sfu/dev2dev-palm
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers
