[EMAIL PROTECTED] wrote: > The php, being what it is, kind of encourages everyone > to do their own thing. The problem is which changes > are appropriate for the whole community, and which are appropriate > to only a few. > > The second problem is an engineering one. Hacks are easy - it is usually > what you do first. Generating a properly documented patch for the > community > is quite another matter. > >
I agree with both points. However, there's a difference between being the code maintainer and an occasional contributor. The way I see it, it is the maintainer's job (with the help of core developers) to make sure patches that go into the distributed codebase are of good enough quality. You, as a contributer which would like to "give back to the community", have a lesser responsibility here. While it would be much nicer if all of us could write code to the highest standard and always supply with quality patches, it's not much of a realistic wish. I believe it's better to have a significant amount of "average quality" submissions - ones which could bring forth new ideas and possibly educate the submitter on how to write better code - than to have few high-quality submissions. This approach demands more patience and work from core developers, namely in picking out the good stuff from the heap, but it encourages users to go ahead and hack the code. It builds a community of developers, not just users. > Take me, for our pilot, there are a few things I have done that I quite > like: > > - Added a kind of automatic custom metric display capability at the > cluster view. Basically > in the cluster view, you get the normal load/network reports, but if > there is a metric in > there that is not a standard one, it goes ahead and displays it along > with the standard ones > (above the little graphs for the individual hosts). This is slightly > less ugly than the array > thing, but it remains true you have no control. Selection capability > would clearly be better. > > I've started working on it. I don't intend on doing it with template magic, since my knowledge of PHP is poor at best, and the extra learning overhead doesn't fit into my time constraints... but providing with some basic functionality, should I obtain permission to contribute it back to the community, would allow others to take it up from there and make sure it fits the "look and feel" of the rest of Ganglia's web interface. Either way, I have a feeling quite a few people would find this feature useful. > - Added a RRD MAX consolidation function as well as the AVERAGE. The PNG > may not > survive the mailing list, but having max and average both displayed is > very effective > for not getting the wrong idea about loads over longer time frames. > > That's an interesting idea - I haven't thought of that. I'd be delighted if you could provide the list with this patch. [snip] > - Added the ability to specify a graph start time as well as a graph > range. So I can say I want > a 15 minute view from 2 hours ago. This is great for diagnosis. It can > take a while before you > realise you need to take a fine grained look at some event in the past. > > I've implemented something similar myself, except I provided with both start and end times, in case someone wants to view usage between Jan 1st and Feb 13th (for example). > - Added a data export function. In a cluster view you get the cluster > data, in a host view you > get the host data. The script looks in the directory and for every > file/metric it finds, it > kind of zippers the lot together based on timestamp and makes a single > (multiple column) > spreadsheet. > > This sounds interesting as well. Again, I'd appreciate it if you could share this patch. > Phew. So I have done quite a bit, but it is ever so ugly. I have not > therefore yet tried > to introduce them back to the community. Maybe one day soon... > > While quality is important, seeing as Ganglia's development has slowed down considerably and seems to be based on bugfixes only lately (many projects go through such phases, mind you), patches which add functionality may be just the incentive people need to get hacking. Even if they seem ugly. It's the basic "if you can do it, so can I" principle I hope could be triggered here. Cheers, Alex > My final comment is that graph.php is a fairly self contained graph > producer. If you want to > do your entire own thing, you interrogate gmetad to discover your > estate, and then invoke > graph.php to get the pictures you want, how you want. > > regards, > richard > > > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Martin > Knoblauch > Sent: 31 January 2006 08:38 > To: Alex Balk; [email protected] > Subject: Re: [Ganglia-general] gmetrics in cluster/grid view > > > Hi Alex, > > what exactely do you have in mind? From your description I am not > really sure. > > Martin > > --- Alex Balk <[EMAIL PROTECTED]> wrote: > > >> Hi all, >> >> >> I'm interested in viewing data gathered from gmetrics in a >> cluster/grid view, sort of like the aggregation graphs for >> load/memory. This would require some changes to the web frontend code >> and I'd like to know, has >> anyone here made such changes? >> >> >> I've written a quick & dirty hack that provides this functionality >> (only cluster-view at the moment) but it requires entering arguments >> to rrdtool into some array in conf.php. Needless to say that's way too >> ugly >> to go in a production environment. >> >> >> My plan is to write a separate interface in which one could choose the >> desired gmetrics, color, graph style and time interval, and the >> graphs >> would be generated accordingly. This interface will be linked from >> each >> cluster/grid view and would display the desired graphs for that view. >> >> >> Your thoughts (and patches..) will be appreciated! >> >> >> Cheers, >> >> Alex >> >> >> >> ------------------------------------------------------- >> This SF.net email is sponsored by: Splunk Inc. Do you grep through log >> > > >> files for problems? Stop! Download the new AJAX search engine that >> makes searching your log files as easy as surfing the web. DOWNLOAD >> SPLUNK! >> >> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 > >> _______________________________________________ >> Ganglia-general mailing list [email protected] >> https://lists.sourceforge.net/lists/listinfo/ganglia-general >> >> >> > > > ------------------------------------------------------ > Martin Knoblauch > email: k n o b i AT knobisoft DOT de > www: http://www.knobisoft.de > > > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep through log > files for problems? Stop! Download the new AJAX search engine that > makes searching your log files as easy as surfing the web. DOWNLOAD > SPLUNK! > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 > _______________________________________________ > Ganglia-general mailing list [email protected] > https://lists.sourceforge.net/lists/listinfo/ganglia-general > > > ------------------------------------------------------------------------ > For more information about Barclays Capital, please > visit our web site at http://www.barcap.com. > > > Internet communications are not secure and therefore the Barclays > Group does not accept legal responsibility for the contents of this > message. Although the Barclays Group operates anti-virus programmes, > it does not accept responsibility for any damage whatsoever that is > caused by viruses being passed. Any views or opinions presented are > solely those of the author and do not necessarily represent those of the > Barclays Group. Replies to this email may be monitored by the Barclays > Group for operational or business reasons. > > ------------------------------------------------------------------------ > > > > ------------------------------------------------------------------------ >
