Hi! > 1) Let the pull request go through the main repository
I think option 1) + adding original authors into collaborators should be good. github also recommends this model. http://help.github.com/pull-requests/ # Option 2) is very complicated... X( On Wed, Sep 22, 2010 at 09:44, Bernard Li <[email protected]> wrote: > Hi all: > > In case you haven't been to our GitHub repository lately, you should > definitely check it out, we now have... > > 8 Gmond Python DSO modules > 30+ Gmetric plugins > > and it's growing -- thanks to all who have contributed code! > > We now have our first discussion regarding policy for the repository. > Here's a specific example: > > User hirose submitted some modules to the ganglia/gmond_python_modules > repository. User drawks wanted to make some edits to one of the > module and therefore forked the repository and submitted a pull > request. > > There are two routes we can go: > > 1) Let the pull request go through the main repository > 2) Have user drawks fork hirose's repository, submit a pull request > against his repo, then when hirose accepted the changes, submit a pull > request against the main repository > > Option 2) seems like a very complicated process, and it is. However, > it allows the original author of the code to maintain ownership and > they are more likely to understand the specific metric collection > domain than the collaborators who can apply pull requests. > > On the other hand, we could also put a disclaimer saying that all code > that has been contributed to the repository may be changed at will by > collaborators. In this case the responsibility of reviewing the > commit will be up to the collaborators who have write access to the > main repo and they may not be domain experts in the code in question. > > I'd like to hear the opinions of the community especially contributors > and of course from users drawks and hirose :-) > > Thanks for your attention. > > Cheers, > > Bernard > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > Ganglia-general mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ganglia-general > -- ひろせ ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ Ganglia-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ganglia-general
