Hi Ron/Bernard,

Thanks for the suggestion Ron.
I had thought to do that (if I had no other option), but really wanted to 
understand why the perfstat_cpu_total metrics had been selected, in preference 
to those of perfstat_partition_total.
I am using Michael's v3.1.2 Aix RPM's (with much thanks), and can confirm that 
they are also built using the perfstat_cpu_total system call.

Bernard, I've included the code mods (diff output below) that I see as 
necessary to do this.
I've adjusted the code in an insular way, so as to not affect anything else 
possibly relying on the returned data from the original perfstat_cpu_total call.
Note though that this patch should be assessed by someone like Michael prior to 
adding it to your code base.

Does seem OK to me though. :-)

cd ganglia-3.1.2/libmetrics/aix
diff orig_metrics.c metrics.c
738a739
>   perfstat_partition_total_t cpu_partition_buffer;
740d740
< 
747a748
>       perfstat_partition_total(NULL,  &cpu_partition_buffer, 
>sizeof(perfstat_partition_total_t), 1);
749,750d749
<       cpu_total = cpu_total_buffer.user +  cpu_total_buffer.sys  
<       +  cpu_total_buffer.idle +  cpu_total_buffer.wait;
751a751,753
>       cpu_total = cpu_partition_buffer.puser +  cpu_partition_buffer.psys  
>       +  cpu_partition_buffer.pidle +  cpu_partition_buffer.pwait;
> 
759,762c761,764
<       cur_cpu_info->user        = cpu_total_buffer.user;
<       cur_cpu_info->sys         = cpu_total_buffer.sys;
<       cur_cpu_info->idle        = cpu_total_buffer.idle;
<       cur_cpu_info->wait        = cpu_total_buffer.wait;
---
>       cur_cpu_info->user        = cpu_partition_buffer.puser;
>       cur_cpu_info->sys         = cpu_partition_buffer.psys;
>       cur_cpu_info->idle        = cpu_partition_buffer.pidle;
>       cur_cpu_info->wait        = cpu_partition_buffer.pwait;


Very Best Regards to all.




      
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Ganglia-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ganglia-general

Reply via email to