On Tue, Mar 6, 2018 at 7:05 PM, Vladimir Kozlov <vladimir.koz...@oracle.com> wrote: > My understanding is currently it is not enough for *HotSpot* changes. You > still need to ask for sponsor to run additional Hotspot tests. >
At FOSDEM 2018, the OpenJDK Lead Mark Reinhold answered my comment that it is still not possible for external committers to push HotSpot changes with the words: "Actually it is possible!" (see 7:51min of [1]) He further detailed: "If you are working on shared code and you run it trough the submission repo ... and all test pass you should be clear to push it." (see 8:16 min of [1]) So if that's not true it is, to put it mildly, at least disappointing. It then seems like Oracle now creates a "fake" submission forest before every FOSDEM (you may remember that we already had a different one before FOSDEM 2017 which could also not be used for submitting, i.e. pushing, real change) just to shine at the "OpenJDK Governing Board Q&A" [2] session. If the submission repo can neither be used for pushing changes directly nor for pushing them manually after the tests executed by the repo have passed, please remove it completely or rename to something like "run_some_random_tests_if_youd_like_to_burn_some_cpu_power_in_the_oracle_cloud-repo". There's really no reason why any developer should use it in that case! 1. If all the tests pass, I have to ask an Oracle developer anyway to run "some other" tests and push my change. So why should I use the submission forest in the first place? 2. If the tests don't pass, I get a cryptic, completely meaningless error mail. Again, I have to ask an Oracle developer to tell me what went wrong. I could have much more easily come to the same result by just asking an Oracle developer to push my change right from the start. He would have run it through "some internal tests" and told me right away what's wrong. In both cases neither I nor the Oracle sponsor gets any benefit from the current submission forest. So Mark, you in your role as OpenJDK Lead, could you please give an authoritative to the question what the submission forest is good for and remove it in the case it turns out to be useless? Thank you and best regards, Volker [1] https://video.fosdem.org/2018/UD2.208/gb_qa.mp4 [2] https://fosdem.org/2018/schedule/event/gb_qa/ > Regards, > Vladimir > > > On 3/6/18 6:51 AM, Lindenmaier, Goetz wrote: >> >> Hi, >> >> What is the status of the tests executed on the JDK submit repo? >> >> Can I push my change if it passes these tests? Or are there still >> tests missing that would be executed by Oracle engineers if they >> sponsor? Are these relevant? >> >> Best regards, >> Goetz. >> >> >
