http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47558

--- Comment #60 from Iain Sandoe <iains at gcc dot gnu.org> 2011-02-05 18:57:20 
UTC ---
(In reply to comment #59)
> I can confirm that the patch in Comment 58 both eliminates the failure in the
> reduced test case from Comment 56 as well as the failure in the dipCoup test 
> in
> xplor-nih. I am less certain that we want the
> current phrasing of the comment...
> 
> +/* FIXME: Work around PR47558 by linking against libSystem ahead of 
> +   libgcc_ext. */

My feeling is that the FIXME should relate to the problem at hand - which is
that our existing _ext design is incompatible with -flat_namespace.  That is
what needs fixing.

> We should arrive at a consensus on whether symbols which overlap between
> libgcc_ext and libSystem should be given priority in libSystem and resolved
> there. This patch achieves this and if we agree this should be the case, the
> comment should instead read...

the way to achieve that is to make a proper 10.6.ver to control which symbols
we wish to export - (but not the subject of this PR).

> +/* Linking libSystem ahead of libgcc_ext prioritizes those overlapping 
> symbols
> in libSystem
> +    over those from libgcc_ext which re-exposes PR42333. */
> 
> This is the correct behavior for the long-run on darwin and we should 
> re-double
> our efforts to get
> <rdar://problem/7457013>,  ___divdc3 slightly wrong, fixed in Lion.

Well, indeed ... highly desirable to have bugs fixed (but that, again, is not
this bug).

However, I'm not going to nail colours to the mast over the wording of the
FIXME - so long as it is not confusing or misleading to some future maintainer
trying to fix the problem ;)

Reply via email to