http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33763

--- Comment #25 from rguenther at suse dot de <rguenther at suse dot de> 
2012-01-12 14:27:12 UTC ---
On Thu, 12 Jan 2012, hubicka at ucw dot cz wrote:

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33763
> 
> --- Comment #24 from Jan Hubicka <hubicka at ucw dot cz> 2012-01-12 14:22:52 
> UTC ---
> > OTOH, it is time to deprecate this extension and warn about it (after
> > all we miscompile this since quite some time, GCC 3.3 and 4.1 already 
> > produce
> > the recursive open - how was this intended to work? ...)  I don't have
> > 3.2 (and 2.95 does not have always_inline).
> 
> pre cgraph compilers handled it in a way that inline body was kept after
> parsing
> extern inline version and inlined into every new parsed function until
> the offline version was reached. Then the function was marked uninlinable,
> offline body was produced and all subsequentely parsed calls was not inlined
> (including calls in the offline body).
> 
> I think extern inlines are sadly rather common to be deprecated...

Well, not deprecating extern inlines but re-definitions in the
same TU which miscompiles once the extern inline is used in that
TU (ok, so you can say in 99% of all cases that won't happen).

Thus, another workaround would be to avoid transitioning the
attribute to the redefinition in merge_decls (under the exact
same condition as we allow the redefinition).

Richard.

Reply via email to