https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78599
--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Formatting-wise yes (though you could leave the parens around (parm_type == NULL) ), but I'm not familiar with this code to actually review it. Plus, patches should go to gcc-patches.