https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79771

--- Comment #6 from Yaakov Selkowitz <yselkowi at redhat dot com> ---
(In reply to Jakub Jelinek from comment #5)
> Do you really need even the zlib.def change?

For standalone zlib, yes; if you try to export a symbol which doesn't exist, ld
errors out.

> That part has been added 5 years ago, so it would surprise me if it didn't
> build even with that.

For standalone zlib, no, we've just been patching it out all this time.

Note that my patch was for the standalone zlib.  OTOH, in-tree zlib should be
built static-only, so zlib.def isn't used either way.

> If that works, the gzguts.h and zlib.h changes is something we can apply to
> gcc's copy until it is resolved upstream.

Ultimately, IMHO we should be encouraging --with-system-zlib on Cygwin (like
most other *NIX), but by all means, feel free to take the patch.

Reply via email to