https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84269
--- Comment #13 from David Malcolm <dmalcolm at gcc dot gnu.org> --- Author: dmalcolm Date: Fri Apr 6 17:36:33 2018 New Revision: 259184 URL: https://gcc.gnu.org/viewcvs?rev=259184&root=gcc&view=rev Log: C++: more std header hints; filter on C++ dialect (PR c++/84269) This patch adds more suggestions as per: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84269#c10 some of which need C++14 and C++17, and some of which use headers that exist in earlier standards. For example, <memory> exists in C++98, but if the user attempts to use std::make_shared with -std=c++98, they are suggested to include <memory>, even if they've already included it. This patch adds the missing names, and fixes the nonsensical suggestions by detecting if the name isn't available yet, based on the user's dialect, and reporting things more intelligently: t.cc: In function 'void test_make_shared()': t.cc:5:8: error: 'make_shared' is not a member of 'std' std::make_shared<int>(); ^~~~~~~~~~~ t.cc:5:8: note: 'std::make_shared' is only available from C++11 onwards gcc/cp/ChangeLog: PR c++/84269 * name-lookup.c (struct std_name_hint): Move out of get_std_name_hint; add field "min_dialect". (get_std_name_hint): Add min_dialect values to all initializers. Add <any>, <atomic>, <bitset>, <condition_variable>, <functional>, <future>, <istream>, <iterator>, <ostream>, <mutex>, <optional>, <shared_mutex>, <string_view>, <thread>, and <variant>. Add fstream, ifstream, and ofstream to <fstream>. Add istringstream, ostringstream, and stringstream to <sstream>. Add basic_string to <string>. Add tuple_element and tuple_size to <tuple>. Add declval to <utility>. Fix ordering of <queue> and <tuple>. Return a std_name_hint, rather than a const char *. (get_cxx_dialect_name): New function. (maybe_suggest_missing_std_header): Detect names that aren't yet available in the current dialect, and instead of suggesting a missing #include, warn about the dialect. gcc/testsuite/ChangeLog: PR c++/84269 * g++.dg/lookup/missing-std-include-6.C: Move std::array and std::tuple here since they need C++11. * g++.dg/lookup/missing-std-include-8.C: New test. * g++.dg/lookup/missing-std-include.C: Move std::array and std::tuple test to missing-std-include-6.C to avoid failures with C++98. Added: trunk/gcc/testsuite/g++.dg/lookup/missing-std-include-8.C Modified: trunk/gcc/cp/ChangeLog trunk/gcc/cp/name-lookup.c trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/g++.dg/lookup/missing-std-include-6.C trunk/gcc/testsuite/g++.dg/lookup/missing-std-include.C