--- Comment #1 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Date: Thu Apr 12 23:44:09 2018
New Revision: 259360
Prevent erroneous "macro had not yet been defined" messages (PR c++/85385)
PR c++/85385 reports an issue where we emit bogus "macro had not yet been
defined" notes when a macro is mis-used:
$ cat test.c
void test ()
$ ./xg++ -B. -c test.c
test.c:5:11: error: macro "MACRO" requires 2 arguments, but only 1 given
test.c: In function ‘void test()’:
test.c:5:3: error: ‘MACRO’ was not declared in this scope
test.c:1: note: it was later defined here
The macro *had* been defined, it was merely misused.
This patch fixes the issue by only issuing the note if the use location
is before the definition location (using linemap_location_before_p).
* name-lookup.c (macro_use_before_def::maybe_make): New function,
checking that the use is indeed before the definition.
(macro_use_before_def::macro_use_before_def): Make private.
(macro_use_before_def::~macro_use_before_def): Make private. Move
check for UNKNOWN_LOCATION to macro_use_before_def::maybe_make.
(lookup_name_fuzzy): Call macro_use_before_def::maybe_make rather
than using new directly.
* g++.dg/diagnostic/macro-arg-count.C: New test.