https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89255

--- Comment #12 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
(In reply to r...@cebitec.uni-bielefeld.de from comment #9)
> > --- Comment #6 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
> > Created attachment 46069 [details]
> >   --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=46069&action=edit
> > Use dg-runtest instead of dg-test
> >
> > (In reply to Iain Buclaw from comment #4)
> >> (In reply to r...@cebitec.uni-bielefeld.de from comment #3)
> >> > 
> >> > FAIL: libphobos.shared/finalize.d -shared-libphobos -ldl execution test
> >> > FAIL: libphobos.shared/finalize.d -shared-libphobos -ldl execution test
> >> > FAIL: libphobos.shared/finalize.d -shared-libphobos -ldl execution test
> >> > FAIL: libphobos.shared/finalize.d -shared-libphobos -ldl execution test
> >> > FAIL: libphobos.shared/finalize.d -shared-libphobos -ldl execution test
> >> > FAIL: libphobos.shared/finalize.d -shared-libphobos -ldl execution test
> >> > FAIL: libphobos.shared/finalize.d -shared-libphobos -ldl execution test
> >> > FAIL: libphobos.shared/finalize.d -shared-libphobos -ldl execution test
> >> > FAIL: libphobos.shared/finalize.d -shared-libphobos -ldl execution test
> >> > FAIL: libphobos.shared/finalize.d -shared-libphobos -ldl execution test
> >> > 
> >> > compilation is run 10 times in exactly the same way!?
> >> > 
> >> 
> >> Maybe something is missing in the part copied from 
> >> GCC_RUNTEST_PARALLELIZE. 
> >> I did see problems copying gcc_parallel_test_run_p and other procedures
> >> locally to the libphobos testsuite, it looked like it replaced itself
> >> incorrectly.
> >
> > Ahh, we're calling dg-test directly, instead of dg-runtest, so there's no
> > protection against parallelized tests.
> >
> > Looking at dejagnu/dg.exp, there's no reason to use dg-test, so switching 
> > all
> > over.
> 
> Yes, that worked fine, thanks.  However, looking at libphobos.sum now,
> there are still 3 tests that show up more than twice (once for each
> multilib):
> 
>       8 PASS: libphobos.cycles/mod1.d (test for excess errors)
>       8 PASS: libphobos.cycles/mod1.d execution test
>       8 PASS: libphobos.cycles/mod2.d (test for excess errors)
>       8 PASS: libphobos.cycles/mod2.d execution test
>       8 PASS: libphobos.cycles/mod3.d (test for excess errors)
>       8 PASS: libphobos.cycles/mod3.d execution test
> 
> The different compilations/executions should be distinguished somehow in
> the test names.

They differ by libphobos_run_args, not by compilation flags.

Maybe I'm running these tests in a lazy way, but would appending the execution
args to the name be sufficient?  And in which place?


libphobos_load:
---
PASS: libphobos.cycles/mod1.d (test for excess errors)
PASS: libphobos.cycles/mod1.d --DRT-oncycle=ignore execution test
PASS: libphobos.cycles/mod1.d (test for excess errors)
PASS: libphobos.cycles/mod1.d --DRT-oncycle=abort execution test
PASS: libphobos.cycles/mod1.d (test for excess errors)
PASS: libphobos.cycles/mod1.d --DRT-oncycle=print execution test
PASS: libphobos.cycles/mod1.d (test for excess errors)
PASS: libphobos.cycles/mod1.d --DRT-oncycle=deprecate execution test
---

libphobos-dg-test:
---
PASS: libphobos.cycles/mod1.d --DRT-oncycle=ignore (test for excess errors)
PASS: libphobos.cycles/mod1.d --DRT-oncycle=ignore execution test
PASS: libphobos.cycles/mod1.d --DRT-oncycle=abort (test for excess errors)
PASS: libphobos.cycles/mod1.d --DRT-oncycle=abort execution test
PASS: libphobos.cycles/mod1.d --DRT-oncycle=print (test for excess errors)
PASS: libphobos.cycles/mod1.d --DRT-oncycle=print execution test
PASS: libphobos.cycles/mod1.d --DRT-oncycle=deprecate (test for excess errors)
PASS: libphobos.cycles/mod1.d --DRT-oncycle=deprecate execution test
---

Reply via email to