https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83237

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hp at gcc dot gnu.org

--- Comment #6 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
A note for the record:

(In reply to pa...@gcc.gnu.org from comment #5)
> Author: paolo
> Date: Sun Dec 24 22:08:52 2017
> New Revision: 255993
> 
> URL: https://gcc.gnu.org/viewcvs?rev=255993&root=gcc&view=rev
> Log:
> 2017-12-24  Michele Pezzutti <mp...@tiscali.it>
> 
>       PR libstdc++/83237
>       * include/bits/random.tcc (poisson_distribution<>::operator()):
>       Fix __x = 1 case - see updated Errata of Devroye's treatise.
>       * testsuite/26_numerics/random/poisson_distribution/operators/
>       values.cc: Add test.

Please don't "add test" to an existing file like that, instead put it in a new
file.

(This method of adding a test can cause side-effects such as a timeout. 
Example: cris-elf which runs in a simulator, now needs >10 minutes on a
"i7-4770K CPU @ 3.50GHz".  I intend to split up the test, as has been done in
the past.)

Also a question: is there a reasonable (much) lower number combination than the 
"testDiscreteDist<100, 2000000>" in the test?  Perhaps that part of the test
can reasonably be disabled for simulator targets?

(Also, it seems this PR should be closed as the original issue has been fixed.)

Reply via email to