https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94331

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Close as FIXED.

  * * *

Now that my big patch has been applied, I tried the example from comment 0
(Fortran part) and comment 1 (C part) and the stand-alone testcases PR93308.f90
 PR93963.f90  PR94327.c  PR94327.f90  PR94331.c  PR94331.f90  PR97046.f90 of
the patch in comment 12.

All pass with -O0 and -Ofast.  (Well, I had to change the expected version
number to 1 (not 0) of comment 1 - as GCC uses "#define CFI_VERSION 1".)


I am not sure whether it makes sense to add any of those testcases or not.
Given that there is already quite some coverage, I have not – but can be easily
convinced to do so.

Thanks, José for the testcases - and the patches, which weren't reviewed. (Tip:
please ping them after a while; otherwise, they might end up unreviewed.)

(I think at the end doing the full inlining of the conversion code made more
sense, but was also a huge effort.)

Reply via email to