https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104132
Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2022-02-04
Assignee|unassigned at gcc dot gnu.org |tschwinge at gcc dot
gnu.org
Ever confirmed|0 |1
--- Comment #1 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Even simpler:
void
f1 (void)
{
#pragma acc kernels
{
int k = -1;
#pragma acc loop
for (k = 0; k < 2; k++)
;
if (k != -1)
__builtin_abort ();
}
}
... does ICE in the very same way.
The following fix fell out of me analyzing PR102330:
--- gcc/omp-expand.cc
+++ gcc/omp-expand.cc
@@ -7776,7 +7776,9 @@ expand_oacc_for (struct omp_region *region, struct
omp_for_data *fd)
expr = build2 (plus_code, iter_type, b,
fold_convert (plus_type, offset));
- expr = force_gimple_operand_gsi (&gsi, expr, false, NULL_TREE,
+ expr = force_gimple_operand_gsi (&gsi, expr,
+ DECL_P (v) && TREE_ADDRESSABLE (v),
+ NULL_TREE,
true, GSI_SAME_STMT);
ass = gimple_build_assign (v, expr);
gsi_insert_before (&gsi, ass, GSI_SAME_STMT);
@@ -7966,7 +7968,9 @@ expand_oacc_for (struct omp_region *region, struct
omp_for_data *fd)
expr = fold_build2 (TRUNC_DIV_EXPR, diff_type, expr, s);
expr = fold_build2 (MULT_EXPR, diff_type, expr, s);
expr = build2 (plus_code, iter_type, b, fold_convert (plus_type,
expr));
- expr = force_gimple_operand_gsi (&gsi, expr, false, NULL_TREE,
+ expr = force_gimple_operand_gsi (&gsi, expr,
+ DECL_P (v) && TREE_ADDRESSABLE (v),
+ NULL_TREE,
true, GSI_SAME_STMT);
ass = gimple_build_assign (v, expr);
gsi_insert_before (&gsi, ass, GSI_SAME_STMT);
... as used in a number of other similar places (when they're not using
'expand_omp_build_assign').
That change seems correct, right? (Jakub?)
