[Bug analyzer/104793] -Wanalyzer-write-to-const and -Wanalyzer-write-to-string-literal should respect attribute((access, write)

[cvs-commit at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104793

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalc...@gcc.gnu.org>:

https://gcc.gnu.org/g:b6eaf90c64f91553c8002f6ee401785a8bc6f94c

commit r12-7595-gb6eaf90c64f91553c8002f6ee401785a8bc6f94c
Author: David Malcolm <dmalc...@redhat.com>
Date:   Thu Mar 10 09:04:03 2022 -0500

    analyzer: check for writes to consts via access attr [PR104793]

    This patch extends:
      -Wanalyzer-write-to-const
      -Wanalyzer-write-to-string-literal
    so that they will check for __attribute__ ((access, ....) on calls to
    externally-defined functions, and complain about read-only regions
    pointed to by arguments marked with a "write_only" or "read_write"
    attribute.

    gcc/analyzer/ChangeLog:
            PR analyzer/104793
            * region-model.cc
            (region_model::check_external_function_for_access_attr): New.
            (region_model::handle_unrecognized_call): Call it.
            * region-model.h
            (region_model::check_external_function_for_access_attr): New decl.
            (region_model::handle_unrecognized_call): New decl.

    gcc/testsuite/ChangeLog:
            PR analyzer/104793
            * gcc.dg/analyzer/write-to-const-2.c: New test.
            * gcc.dg/analyzer/write-to-function-1.c: New test.
            * gcc.dg/analyzer/write-to-string-literal-2.c: New test.
            * gcc.dg/analyzer/write-to-string-literal-3.c: New test.
            * gcc.dg/analyzer/write-to-string-literal-4.c: New test.

    Signed-off-by: David Malcolm <dmalc...@redhat.com>