https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104997
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by David Malcolm <dmalc...@gcc.gnu.org>: https://gcc.gnu.org/g:160b095fc9ded4eaa2bf4d49bd97319f4aabff0a commit r12-7782-g160b095fc9ded4eaa2bf4d49bd97319f4aabff0a Author: David Malcolm <dmalc...@redhat.com> Date: Wed Mar 23 08:32:17 2022 -0400 analyzer: fix ICE adding note to disabled diagnostic [PR104997] gcc/analyzer/ChangeLog: PR analyzer/104997 * diagnostic-manager.cc (diagnostic_manager::add_diagnostic): Convert return type from "void" to "bool", reporting success vs failure to caller, for both overloads. * diagnostic-manager.h (diagnostic_manager::add_diagnostic): Likewise. * engine.cc (impl_region_model_context::warn): Propagate return value from diagnostic_manager::add_diagnostic. gcc/testsuite/ChangeLog: PR analyzer/104997 * gcc.dg/analyzer/write-to-string-literal-4-disabled.c: New test, adapted from write-to-string-literal-4.c. Signed-off-by: David Malcolm <dmalc...@redhat.com>
