https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119324
--- Comment #2 from Robert Dubner <rdubner at gcc dot gnu.org> --- (In reply to David Binderman from comment #0) > I tried out the static analyser cppcheck on > the source code of /cobol/. > > The most important things it said were: David, I am not familiar with cppcheck. I have installed it, but when I try to run it I don't see what you are describing here. Can you tell me how to configure and run cppcheck to duplicate these results? Thanks. > > 1. > > gcc/cobol/symbols.cc:246:64: performance: Function parameter 'args' should > be passed by const reference. [passedByValue] > > 2. > > gcc/cobol/lexio.cc:854:56: performance: Function parameter 'cm' should be > passed by const reference. [passedByValue] > > 3. > > gcc/cobol/symfind.cc:503:55: performance: Function parameter 'names' should > be passed by const reference. [passedByValue] > > 4. > > gcc/cobol/genapi.cc:1777:78: style: Clarify calculation precedence for '&' > and '?'. [clarifyCalculation] > > 5. > > gcc/cobol/genapi.cc:1778:78: style: Clarify calculation precedence for '&' > and '?'. [clarifyCalculation] > > 6. > > gcc/cobol/genapi.cc:15638:25: warning: Identical inner 'if' condition is > always true. [identicalInnerCondition] > > 7. > > gcc/cobol/genapi.cc:16702:11: warning: Identical inner 'if' condition is > always true. [identicalInnerCondition]
