https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108108

Jürg Billeter <j at bitron dot ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |j at bitron dot ch

--- Comment #5 from Jürg Billeter <j at bitron dot ch> ---
Created attachment 62817
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=62817&action=edit
Proposed patch

The incomplete dependency output causes issues with recc¹ with at least one
project² that has multiple identical header files (dummy files that are
practically empty except for `#pragma once`).

The attached patch fixes the issue by also comparing `st_dev` and `st_ino` in
addition to `st_mtime` and contents. This seems like a simple improvement to me
and shouldn't change the behavior with regards to symlinks and hardlinks.

Is this something that may be acceptable or can anyone think of a reason right
away why this would not be the right solution? I've tested it manually but
haven't run the testsuite yet.

¹ https://buildgrid.gitlab.io/buildbox/buildbox/recc.html
² E.g., `missing_keyctl.h` and `missing_sched.h` in
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/tree/main/src/libnm-systemd-shared/sd-adapt-shared

Reply via email to