https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117935
--- Comment #13 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The trunk branch has been updated by Andrew Pinski <[email protected]>: https://gcc.gnu.org/g:fdf84733a30b32e201334092f56efe10451c6147 commit r16-7752-gfdf84733a30b32e201334092f56efe10451c6147 Author: Andrew Pinski <[email protected]> Date: Thu Feb 26 12:06:51 2026 -0800 phiopt: Reject hot/cold predictors for early phiopt [PR117935] In this case, early phiopt would get rid of the user provided predicator for hot/cold as it would remove the basic blocks. The easiest and best option is for early phi-opt don't do phi-opt if the middle basic-block(s) have either a hot or cold predict statement. Then after inlining, jump threading will most likely happen and that will keep around the predictor. Note this only needs to be done for match_simplify_replacement and not the other phi-opt functions because currently only match_simplify_replacement is able to skip middle bb with predicator statements in it. This allows for MIN/MAX/ABS/NEG still even with the predicators there as those will less likely be jump threaded later on. The main thing that is rejected is ssa names that are alone where one of the comparisons operands is that one or if we produce a comparison from the phiopt. Changes since v1: * v2: Only reject if the result was the comparison. Bootstrapped and tested on x86_64-linux-gnu. PR tree-optimization/117935 gcc/ChangeLog: * tree-ssa-phiopt.cc (contains_hot_cold_predict): New function. (match_simplify_replacement): Return early if early_p and one of the middle bb(s) have a hot/cold predict statement. gcc/testsuite/ChangeLog: * gcc.dg/predict-24.c: New test. * gcc.dg/predict-25.c: New test. Signed-off-by: Andrew Pinski <[email protected]>
