https://gcc.gnu.org/bugzilla/show_bug.cgi?id=125942

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2026-06-23
     Ever confirmed|0                           |1
                 CC|                            |rguenth at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Drea Pinski from comment #0)
[...]
> And maybe even:
> gsi_insert_iterator insert_i = gsi_insert_at_begining_bb (bb);
> gsi_insert (insert_i, g);
> 
> Which inserts at the beginning of the basic block.  This shows up in
> tree-ssa-phiopt and a few other places too.

Possibly

  auto insert_i = gsi_insert_iterator::after_labels (bb);

etc.?  Also 'gsi' is somewhat redundant (gimple-stmt-iterator), so
ginsert_iterator would be shorter.  There's some inconsistency in
GCC with respect to the use of *_iterator* and *_iter*, I'd prefer
the shorter variant.  ginsert_iter (or to match up with
gimple_stmt_iterator, gimple_stmt_insert_iterator or gimple_insert_iterator).
(we have inconsistent gphi_iterator).

Hah, bikeshedding.

Reply via email to