https://gcc.gnu.org/bugzilla/show_bug.cgi?id=128618

Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #4 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
(In reply to Hans-Peter Nilsson from comment #3)
> (In reply to Jerry DeLisle from comment #1)
> > Created attachment 66134 [details]
> > Draft patch to fix this
> > 
> > Hi Hans-Peter, can you test this to see if it fixes it. If so I can get it
> > pushed today.
> > 
> > Thanks for the report. (I did get word of this from others.)
> 
> This one works too, thanks.  In the meantime, I committed mine, since it
> came with a ChangeLog entry.
> 
> They both have their merits: mine mostly for simplicity, and that I believe
> most common 32-bit systems running fortran do have 64-bit atomics, so mine
> affecting more code than yours, is unlikely to matter in practice.  Having
> said that, feel absolutely free to revert it and apply yours instead!

I OKed yours because it was simpler. So I tossed it over to the LLM to compare.
The three pages of verbosity suggest your patch leaves an obscure opportunity
for a race condition. The patch I attached here avoids that but must not be
layered on top of yours to do so.

So I think I will commit the one I attached with yours backed out. (leaning
toward the robust). The commit logs are easy enough to do

Reply via email to