Jakub Jelinek <ja...@redhat.com> writes: > On Tue, Mar 08, 2011 at 04:27:04PM +0100, Rainer Orth wrote: >> >> 2011-03-08 Jakub Jelinek <ja...@redhat.com> >> >> >> >> * go.test/go-test.exp: For goroutines.go test pass >> >> max($[`ulimit -u`/4], 10000) as first argument, or 64 as a safe >> >> default. >> > >> > How about if we do this unless the environment variable >> > GCCGO_RUN_ALL_TESTS is set, so that people have a way to run the full >> > testsuite. I can also change the libgo testsuite to only run the >> > networking tests if that environment variable is set. This patch is OK >> > with that change. Thanks for doing it. >> >> Alternatively, one might use GCC_TEST_RUN_EXPENSIVE, which is already >> used to control dg-require-effective-target run_expensive_tests. This >> avoids separate mechanisms per testsuite/language. > > I guess [getenv GCC_TEST_RUN_EXPENSIVE] != "" could be a usable test here, > if false it could always use 64 threads or something like that, if true > it should IMNSHO still bound it to at most max($[`ulimit -u`/2], 10000) > when ulimit -u is available, because running the thread when it is known > to break other things is a bad idea. > But of course if Ian wants to guard networking libgo tests with some env > var, GCC_TEST_RUN_EXPENSIVE probably isn't an env var to use...
I don't really care what environment variable we use, I just want some way to run the full test, without having DejaGNU silently change the test on me. It's perfectly reasonable to have the default check ulimit, I just want some way to not check it. Ian
