Hi,

On Wed, 27 Apr 2011, Jan Hubicka wrote:

> *************** false_predicate (void)
> *** 163,168 ****
> --- 166,195 ----
>   }
>   
>   
> + /* Return true if P is (false).  */
> + 
> + static inline bool
> + true_predicate_p (struct predicate *p)

Comment doesn't match function.

> + {
> +   return !p->clause[0];
> + }
> + 
> *************** add_clause (struct predicate *p, clause_
> *** 207,222 ****
>   {
>     int i;
>     int insert_here = -1;
>     /* True clause.  */
>     if (!clause)
>       return;
>   
>     /* Flase clause makes the whole predicate false.  Kill the other 
> variants.  */

s/Flase/False/

> --- 688,719 ----
>      Indent by INDENT.  */
>   
>   static void
> ! dump_inline_edge_summary (FILE * f, int indent, struct cgraph_node *node,
> !                       struct inline_summary *info)
>   {

New arguments have to be documented.

> ! estimate_calls_size_and_time (struct cgraph_node *node, int *size, int 
> *time,
> !                           clause_t possible_truths)

Same.

> ! /* Translate all conditions from callee representation into caller 
> representation and
> !    symbolically evaluate predicate P into new predicate.
> ! 
> !    INFO is inline_summary of function we are adding predicate into, 
> CALLEE_INFO is summary
> !    of function predicate P is from. OPERAND_MAP is array giving callee 
> formal IDs the
> !    caller formal IDs.

Some word is missing in the last sentence.


>      POSSSIBLE_TRUTHS is clausule of all callee conditions that

"POSSIBLE_TRUTHS" and "a/the clause"


Ciao,
Michael.

Reply via email to