On Tue, 3 May 2011, Gerald Pfeifer wrote:
> <On Wed, 27 Apr 2011, Michael Witten wrote:
> > sed -i "s/[ $(printf '\t')]\{1,\}\$//" trunk/gcc/doc/extend.texi
>
> I believe we usually don't do whitespace changes just for the sake
> of cleaning up things.
>
> Unless someone else indicates otherwise, I believe this patch is
> rejected.
I think we *should* make such formatting cleanups (not just trailing
whitespace removal, but other changes to match formatting conventions,
including fixing leading whitespace in C code to use tabs where it doesn't
as well as more visible changes) - as long as we are agreed on what the
convention is to follow (see
<http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00393.html> and thread
regarding conventions for whitespace after VEC etc., for example). (But
not (a) in testcases, where I don't think there's any need to follow
consistent conventions, and (b) in code imported from other upstream
sources, where such fixes are not a good enough reason to diverge from
upstream.)
However, given the reaction when HJ checked in a trailing whitespace
removal patch, it seems this is controversial.
--
Joseph S. Myers
jos...@codesourcery.com
