On 05/07/2011 07:48 PM, Ville Voutilainen wrote:
+static tree set_virt_specifiers (tree decl, cp_virt_specifiers specifiers)
The name of the function needs to be at the beginning of the line.
+ else
+ virt_specifier = VIRT_SPEC_UNSPECIFIED;
+
+ if (!virt_specifier)
+ break;
Using a named constant one one line and then testing for a boolean value
on the next line is unclear. How about just "else break;"?
+/* Non-static member functions have an optional virt-specifier-seq.
+ There is a VIRT_SPEC value for each virt-specifier.
+ They can be combined by bitwise-or to form the complete set of
+ virt-specifiers for a member function. */
+enum virt_specifier
+ {
+ VIRT_SPEC_UNSPECIFIED = 0x0,
+ VIRT_SPEC_FINAL = 0x1,
+ VIRT_SPEC_OVERRIDE = 0x2
+ };
This should be in cp/cp-tree.h.
Otherwise, looks pretty good.
Jason
