Mike Stump <mikest...@comcast.net> writes:
> On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote:
>> * lto.c (promote_var): Only set VISIBILITY_HIDDEN if
>> HAVE_GAS_HIDDEN.
>
> This looks wrong, there are more things that have visibility than those
> things that use GAS and have .hidden. Darwin I think is one of them. ?
> cygming.h seems to be another.
Now that Darwin has been switched to define HAVE_GAS_HIDDEN, is the
lto.c part ok?
I've re-bootstrapped both patches together on i386-apple-darwin9.8.0,
powerpc-apple-darwin9.8.0, i386-pc-solaris2.8 and i386-pc-solaris2.11
without regressions; as expected the failure on Solaris 8/x86 is gone.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
