-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/10/11 13:18, Easwaran Raman wrote:
>>> I am not sure I understand the problem here. If there is a wild read >>> from asm, the instruction has the wild_read flag set. The if statement >>> checks if that flag is set and if so it clears the bitmap - which was >>> the original behavior. Originally, only if read_rec is non NULL you >>> need to recompute the kill set. Now, even if read_rec is NULL, >>> non_frame_wild_read could be set requiring the kill set to be >>> modified, which is what this patch does. In fact, isn't what you have >>> written above the equivalent to what is in the patch as '/* Leave this >>> clause unchanged */' is the same as >>> >>> if (dump_file) >>> fprintf (dump_file, "regular read\n"); >>> scan_reads_nospill (insn_info, v, NULL); >>> >>> >>> -Easwaran >>> > >> Ping. I have changed the test case to use int and added another test >> case that shows DSE doesn't happen when the struct instance is >> volatile (wild_read gets set in that case) > > > What's the purpose behind using unit64_t in the testcase? Somehow I > suspect using int64_t means the test is unlikely not going to work > across targets with different word sizes. Sorry for the exceedingly long wait. Things have been a bit crazy the last several weeks. On a positive note, re-reading things now I think my objection/comment was mis-guided. Patch approved, and again, sorry for the absurdly long period of non-responsiveness. jeff -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJN942IAAoJEBRtltQi2kC7Fj4IAIUvXsEKHZEKHS2k/psJWyaM Uo/vW3CLydRP0+Np/VVSwzHlmWfdWmOj1WPw1Svhvr4gP8BrZ13okVv5jbw1Hh3Y R4mShXFK5eYzmGx5wL54hOze5zViN3gomNGbDAAhk6TCzNXmPyLT/6V1tLFTNhD5 6zOiW8pXh9ik6qTTCKbG0EMuJXDnIbYrJs4d/gHFerUgmRPc8adKjF3PCngD3F4r 40n9W/UxUejYUddavDW1fIdALWYc56F3glplFsII7SMnOmih8MTFYOvk6SZsLS5O G2nzmnUuwt6tPWTyk9bpVKQi5dn8MmLkM13w22t36GKIg6OER2KfUdv44dgE7yw= =o7AI -----END PGP SIGNATURE-----
