Re: [Patch ARM] Improve guality tests - part 1 - pr36728-1.c

[Ramana Radhakrishnan]

On 04/02/2015 11:40, Jakub Jelinek wrote:
On Wed, Feb 04, 2015 at 11:33:19AM +0000, Ramana Radhakrishnan wrote:
--- a/gcc/testsuite/gcc.dg/guality/pr36728-1.c
+++ b/gcc/testsuite/gcc.dg/guality/pr36728-1.c
@@ -49,5 +49,6 @@ main ()
    int l = 0;
    asm ("" : "=r" (l) : "0" (l));
    a = foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
+  asm volatile ( "" : : "r" (l));

Please remove the space before "".

--- a/gcc/testsuite/gcc.dg/guality/pr36728-2.c
+++ b/gcc/testsuite/gcc.dg/guality/pr36728-2.c
@@ -49,5 +49,6 @@ main ()
    int l = 0;
    asm ("" : "=r" (l) : "0" (l));
    a = foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
+  asm ("" :  : "r" (l));

Please add volatile, and remove the extra space in between :  :

--- a/gcc/testsuite/gcc.dg/guality/pr36728-3.c
+++ b/gcc/testsuite/gcc.dg/guality/pr36728-3.c
@@ -47,5 +47,6 @@ main ()
    int l = 0;
    asm volatile ("" : "=r" (l) : "0" (l));
    foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
+  asm volatile ( "" : : "r" (l));

See the 1st comment.

--- a/gcc/testsuite/gcc.dg/guality/pr36728-4.c
+++ b/gcc/testsuite/gcc.dg/guality/pr36728-4.c
@@ -47,5 +47,6 @@ main ()
    int l = 0;
    asm volatile ("" : "=r" (l) : "0" (l));
    foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
+  asm volatile ( "" : "r" (l));

Likewise.  Also one : is missing, wonder how this could compile.


Bah - only saw the reduction in testcases.

Now corrected and checked on armhf that number of tests failing reduces 
as expected and the pr36728-4.c test runs and shows no failures on 
arm-linux-gnueabihf

Applied with the changes suggested as r220398.

Ramana



Ramana

        Jakub

diff --git a/gcc/testsuite/gcc.dg/guality/pr36728-1.c 
b/gcc/testsuite/gcc.dg/guality/pr36728-1.c
index ba7a6c2..0ab475a 100644
--- a/gcc/testsuite/gcc.dg/guality/pr36728-1.c
+++ b/gcc/testsuite/gcc.dg/guality/pr36728-1.c
@@ -49,5 +49,6 @@ main ()
   int l = 0;
   asm ("" : "=r" (l) : "0" (l));
   a = foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
+  asm volatile ("" :: "r" (l));
   return 0;
 }
diff --git a/gcc/testsuite/gcc.dg/guality/pr36728-2.c 
b/gcc/testsuite/gcc.dg/guality/pr36728-2.c
index 6daa021..7ba8663 100644
--- a/gcc/testsuite/gcc.dg/guality/pr36728-2.c
+++ b/gcc/testsuite/gcc.dg/guality/pr36728-2.c
@@ -49,5 +49,6 @@ main ()
   int l = 0;
   asm ("" : "=r" (l) : "0" (l));
   a = foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
+  asm volatile ("" :: "r" (l));
   return 0;
 }
diff --git a/gcc/testsuite/gcc.dg/guality/pr36728-3.c 
b/gcc/testsuite/gcc.dg/guality/pr36728-3.c
index bb2c067..4700d50 100644
--- a/gcc/testsuite/gcc.dg/guality/pr36728-3.c
+++ b/gcc/testsuite/gcc.dg/guality/pr36728-3.c
@@ -47,5 +47,6 @@ main ()
   int l = 0;
   asm volatile ("" : "=r" (l) : "0" (l));
   foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
+  asm volatile ("" :: "r" (l));
   return 0;
 }
diff --git a/gcc/testsuite/gcc.dg/guality/pr36728-4.c 
b/gcc/testsuite/gcc.dg/guality/pr36728-4.c
index fee79c4..bf6e9e9 100644
--- a/gcc/testsuite/gcc.dg/guality/pr36728-4.c
+++ b/gcc/testsuite/gcc.dg/guality/pr36728-4.c
@@ -47,5 +47,6 @@ main ()
   int l = 0;
   asm volatile ("" : "=r" (l) : "0" (l));
   foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
+  asm volatile ("" :: "r" (l));
   return 0;
 }