> 
> Half of FAILs are gone, but the rest is correctly merged (alignment matches). 
> Thus I would omit ICF
> in this testcase. I'm going to install the patch.
> 
> Thanks,
> Martin

> >From 60c5fdc5d5bab2d26a43813ffebda247c8dd1fce Mon Sep 17 00:00:00 2001
> From: mliska <mli...@suse.cz>
> Date: Fri, 27 Feb 2015 21:49:46 +0100
> Subject: [PATCH 1/4] ICF is more strict about non-common function and var
>  attributes.
> 
> gcc/ChangeLog:
> 
> 2015-02-28  Martin Liska  <mli...@suse.cz>
>           Jan Hubicka   <hubi...@ucw.cz>
> 
>       * ipa-icf-gimple.c (func_checker::compare_variable_decl):
>       Validate variable alignment.
>       * ipa-icf.c (sem_function::equals_private): Be more precise
>       about non-common function attributes.
>       (sem_variable::equals): Likewise.
> 
> gcc/testsuite/ChangeLog:
> 
> 2015-03-01  Martin Liska  <mli...@suse.cz>
>           Jan Hubicka   <hubi...@ucw.cz>
> 
>       * gcc.target/i386/stackalign/longlong-2.c: Omit ICF.

OK then.

Thanks!  Are we ready to close the PR?
Honza

Reply via email to