On Wed, May 20, 2015 at 9:11 PM, Joseph Myers <jos...@codesourcery.com> wrote:
> On Wed, 20 May 2015, Alex Velenko wrote:
>
>> Hi,
>>
>> This patch prevents arm_thumb1_ok XPASS in sibcall-3.c and sibcall-4.c
>> testcases. Sibcalls are not ok for Thumb1 and testcases need to be fixed.
>
> arm_thumb1_ok means "this is an ARM target where -mthumb causes Thumb-1 to
> be used". It only ever makes sense to use it in tests that use an
> explicit -mthumb, which these tests don't.
>
> If you want to check "is this test being built for Thumb-1 by the multilib
> options", use arm_thumb1.
>
Alex, so while you are here - why don't you improve the documentation
in sourcebuild.texi by
1. documenting arm_thumb1
2. distinguishing that from arm_thumb1_ok which just says
`ARM target generates Thumb-1 code for @code{-mthumb}.'
and that is just meaningless.
regards
Ramana
> --
> Joseph S. Myers
> jos...@codesourcery.com
