> Please mark this pattern with (set_attr "type" "multiple").

Done.

> While I suspect that stack probing is done before any insns with invalid
> constants in the function, it would be better to model the length of
> this insn so that the minipool logic is not confused later in terms of
> placement of constant pools.

OK, I can put an upper bound.

> Shouldn't the pattern contain clobbers for the CC register or is that
> unnecessary for the same reason as above ?

That's unnecessary, UNSPEC_VOLATILEs are optimization barriers so no CC-
related instructions can be moved up to before the instruction.

> Additionally please add
> 
> (set_attr "conds" "clob")
> 
> to this pattern so that the CCFSM state machine doesn't go awry in any
> of these cases.

Also done.

-- 
Eric Botcazou

Reply via email to