On 06/24/2015 09:40 PM, Jeff Law wrote:
On 06/24/2015 05:29 PM, Segher Boessenkool wrote:
A few define_split's in the i386 backend modify RTL in place. This does
not work. This patch fixes all cases that do PUT_MODE on existing RTL.
Bootstrapped and tested; no regressions. Is this okay for trunk?
Hrm, this wants the testcase in that PR added I suppose. Will send
it separately.
Segher
2015-06-24 Segher Boessenkool <seg...@kernel.crashing.org>
* config/i386/i386.md (various splitters): Use copy_rtx before
doing PUT_MODE on operands.
Are the copies really needed? If we're slamming a mode into an
ix86_comparison_operator, we should be safe since those can't be shared.
Copying is just wasteful.
It might be worth verifying that something else hasn't created shared
RTL in violation of the RTL sharing assumptions.
Jeff
