Re: [PATCH] Check dominator info in compute_dominance_frontiers

[Tom de Vries]

On 23/06/15 11:31, Richard Biener wrote:
On Mon, Jun 22, 2015 at 7:10 PM, Tom de Vries <tom_devr...@mentor.com> wrote:
On 22/06/15 13:47, Richard Biener wrote:

(eventually also for the case where we
end up only computing the fast-query stuff).


Like this?
...
diff --git a/gcc/dominance.c b/gcc/dominance.c
index 9c66ca2..58fc6fd 100644
--- a/gcc/dominance.c
+++ b/gcc/dominance.c
@@ -679,6 +679,12 @@ calculate_dominance_info (enum cdi_direction dir)
        free_dom_info (&di);
        dom_computed[dir_index] = DOM_NO_FAST_QUERY;
      }
+  else
+    {
+#if ENABLE_CHECKING
+      verify_dominators (CDI_DOMINATORS);
+#endif
+    }

    compute_dom_fast_query (dir);

Yeah.


I realized we actually want to verify 'dir' rather than 
'CDI_DOMINATORS'. The patch also fixes this for the early-out verification.

Bootstrapped and reg-tested on x86_64.

Committed to trunk.

Thanks,
- Tom

Verify reused dominators info in calculate_dominance_info

2015-06-24  Tom de Vries  <t...@codesourcery.com>

	* dominance.c (calculate_dominance_info): Fix verify_dominators call
	argument.  Call verify_dominator when reusing dominator info.
---
 gcc/dominance.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gcc/dominance.c b/gcc/dominance.c
index 9c66ca2..fb61596 100644
--- a/gcc/dominance.c
+++ b/gcc/dominance.c
@@ -648,7 +648,7 @@ calculate_dominance_info (enum cdi_direction dir)
   if (dom_computed[dir_index] == DOM_OK)
     {
 #if ENABLE_CHECKING
-      verify_dominators (CDI_DOMINATORS);
+      verify_dominators (dir);
 #endif
       return;
     }
@@ -679,6 +679,12 @@ calculate_dominance_info (enum cdi_direction dir)
       free_dom_info (&di);
       dom_computed[dir_index] = DOM_NO_FAST_QUERY;
     }
+  else
+    {
+#if ENABLE_CHECKING
+      verify_dominators (dir);
+#endif
+    }
 
   compute_dom_fast_query (dir);
 
-- 
1.9.1