Hi,
On 07/01/2015 10:45 PM, Andreas Schwab wrote:
Paolo Carlini <paolo.carl...@oracle.com> writes:
@@ -972,21 +972,20 @@ ucn_valid_in_identifier (cpp_reader *pfile, cppcha
or 0060 (`), nor one in the range D800 through DFFF inclusive.
*PSTR must be preceded by "\u" or "\U"; it is assumed that the
- buffer end is delimited by a non-hex digit. Returns zero if the
- UCN has not been consumed.
+ buffer end is delimited by a non-hex digit. Returns one if the
+ UCN has not been consumed, zero otherwise.
The name of the function would make more sense if it returned a boolean
with true meaning success.
To be clear (the diff can be a little confusing) we are talking about
_cpp_valid_ucn, the name of the function I'm patching. That said, I'm of
course open to proposals about a better name for the patched function.
Likewise for the values returned, which I picked for consistency with
all the other functions in libcpp, the usual "unix" convention.
Paolo.
