On Thu, Jul 2, 2015 at 2:03 PM, Ramana Radhakrishnan <ramana....@googlemail.com> wrote: > How about a testcase or 2 or mentioning if it is covered by existing > testcases ?
The patch fixes a test in testsuite/gcc.dg/graphite/ when removing the use of limit_scops(). Maybe the commit message could contain the name of the test that it fixed. The patch that removes limit_scops() is in my opinion trivial, and will be submitted for review once we fixed all the errors it can cause (code gen, scop translation to polyhedral, etc.) We will also fix bootstrap with graphite enabled, and then we will fix all problems in bootstrap with limit_scops() removed. I will also add a buildbot tracking nightly bootstraps with -floop-* and -fgraphite-identity. > And Aditya you may find it instructive to read this > https://gcc.gnu.org/contribute.html#patches > Agreed. Thanks for the feedback. Sebastian > regards > Ramana > > >> Thanks, >> Sebastian >> >>>> --- >>>> gcc/graphite-sese-to-poly.c | 7 +++---- >>>> 1 file changed, 3 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/gcc/graphite-sese-to-poly.c b/gcc/graphite-sese-to-poly.c >>>> index 271c499..78f10e4 100644 >>>> --- a/gcc/graphite-sese-to-poly.c >>>> +++ b/gcc/graphite-sese-to-poly.c >>>> @@ -2458,11 +2458,10 @@ rewrite_cross_bb_scalar_deps (scop_p scop, >>>> gimple_stmt_iterator *gsi) >>>> handle_scalar_deps_crossing_scop_limits (scop, def, stmt); >>>> >>>> FOR_EACH_IMM_USE_STMT (use_stmt, imm_iter, def) >>>> - if (gimple_code (use_stmt) == GIMPLE_PHI >>>> - && (res = true)) >>>> + if (gphi *phi = dyn_cast <gphi *> (use_stmt)) >>>> { >>>> - gphi_iterator psi = gsi_start_phis (gimple_bb (use_stmt)); >>>> - >>>> + res = true; >>>> + gphi_iterator psi = gsi_for_phi (phi); >>>> if (scalar_close_phi_node_p (gsi_stmt (psi))) >>>> rewrite_close_phi_out_of_ssa (scop, &psi); >>>> else >>>> >>>
