On 07/09/2015 03:19 AM, Tom de Vries wrote:
On 09/07/15 05:33, Jeff Law wrote:
On 07/07/2015 09:58 AM, Tom de Vries wrote:
[Big snip]


0001-Add-rewrite_virtuals_into_loop_closed_ssa.patch


Add rewrite_virtuals_into_loop_closed_ssa

2015-07-07  Tom de Vries<t...@codesourcery.com>

    * tree-cfg.c (get_virtual_phi): New function.
    * tree-cfg.h (get_virtual_phi): Declare.
    * tree-ssa-loop-manip.c (replace_uses_in_dominated_bbs)
    (rewrite_virtuals_into_loop_closed_ssa): New function.
    * tree-ssa-loop-manip.h (rewrite_virtuals_into_loop_closed_ssa):
    Declare.
    * tree-parloops.c (replace_uses_in_bbs_by): Remove.
    (transform_to_exit_first_loop_alt): Use
    rewrite_virtuals_into_loop_closed_ssa.

So how is the testcase in 56113 affected by this change (compile-time
and memory usage?)  I didn't see any discussion of that in the thread
from June.


Hi Jeff,

rewrite_virtuals_into_loop_closed_ssa is only active for loops that are
transformed by parloops (which is off by default).

The example in PR56113 at n == 1000 only contains one loop, with
!single_dom_exit, so if parloops is switched on, it doesn't transform
the loop.
Opps. Nevermind, obviously not appropriate since you're not rewriting into LCSSA in the general case, just those transformed by parloops ;-)

jeff

Reply via email to