On 8/27/2015 2:26 PM, Jonathan Wakely wrote: > > N.B. please CC the libstdc++ list on all libstdc++ patches. > The tests on DragonFly look excellent now, nice work.
Okay, noted for the future. > I think that should probably be defined on FreeBSD too now, so that > the _GLIBCXX_USE_C99_DYNAMIC checks come into effect. I actually doubt this is valid for FreeBSD. That platform is missing C99 functions in libm. Once the FreeBSD libm is augmented, then it should be set. However, FreeBSD should evaluate switching from generic locale support to DragonFly locale support. It may even work out of the box (collating pending getting collation support from DragonFly which is already in the works). > Committed to trunk with only minor changes to remove some trailing > whitespace in config/os/bsd/dragonfly/ctype_configure_char.cc and to > capitalize a couple of ChangeLog lines. > > Thanks for the ongoing improvements to DragonFly support. Great! I had caught those whitespace changes when imported into DragonFly base but I must have forgotten to apply those changes to version 2 of the patch set. Thanks for review and I'm glad they were high quality. Regards, John
