Re: [google][gcc-4_9] Remove unused key field in gcov_fn_info

[Xinliang David Li]

       else
         {
           gfi_ptr = gi_ptr->functions[f_ix];
-          if (gfi_ptr && gfi_ptr->key == gi_ptr)
+          if (gfi_ptr)
             length = GCOV_TAG_FUNCTION_LENGTH;
-          else
-            length = 0;
         }

The removal of 'else' path seems wrong.

David


On Tue, Sep 29, 2015 at 1:46 PM, Rong Xu <x...@google.com> wrote:
> Hi,
>
> This patch is for google/gcc-4_9 branch.
>
> The 'key' field in gcov_fn_info is designed to allow gcov function
> data to be COMDATTed, but the comdat elimination never works. This
> patch removes this field to reduce the instrumented object size.
>
> Thanks,
>
> -Rong