Re: [PATCH 2/3] [ARM] PR63870 Mark lane indices of vldN/vstN with appropriate qualifier

[Alan Lawrence]

On 07/10/15 00:59, charles.bay...@linaro.org wrote:

diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md
index 2667866..251afdc 100644
--- a/gcc/config/arm/neon.md
+++ b/gcc/config/arm/neon.md
@@ -4261,8 +4261,9 @@ if (BYTES_BIG_ENDIAN)
                      UNSPEC_VLD1_LANE))]
    "TARGET_NEON"
  {
-  HOST_WIDE_INT lane = INTVAL (operands[3]);
+  HOST_WIDE_INT lane = ENDIAN_LANE_N(<MODE>mode, INTVAL (operands[3]));
    HOST_WIDE_INT max = GET_MODE_NUNITS (<MODE>mode);
+  operands[3] = GEN_INT (lane);
    if (lane < 0 || lane >= max)
      error ("lane out of range");

I'm just wondering whether these 'lane out of range' error messages can ever be 
triggered now we have all the other checking? Can we now remove them (perhaps in 
a followup patch)?

Cheers, Alan