On 10/06/2015 06:48 AM, Bernd Schmidt wrote:
On 10/06/2015 01:40 AM, Mikhail Maltsev wrote:

-#ifdef ENABLE_CHECKING
+#if CHECKING_P
        /* Check that the addresses are consecutive.  */
        e = XEXP (SET_DEST (e), 0);
        if (GET_CODE (e) == PLUS)
diff --git a/gcc/config/bfin/bfin.c b/gcc/config/bfin/bfin.c
index a131053..e53fe6d 100644
--- a/gcc/config/bfin/bfin.c
+++ b/gcc/config/bfin/bfin.c
@@ -3811,8 +3811,7 @@ hwloop_optimize (hwloop_info loop)
        edge e;
        edge_iterator ei;

-#ifdef ENABLE_CHECKING
-      if (loop->head != loop->incoming_dest)
+      if (CHECKING_P && loop->head != loop->incoming_dest)
      {

This stuff also seems inconsistent. Why use CHECKING_P instead of
flag_checking? Why use #if sometimes and if in other cases?
No idea :-)

I think we ought to go through this patch and convert the #if stuff to (flag_checking) as much as possible. Given I've got a config-list.mk build ready to go, I'll go ahead and do that update now so it'll pick up those changes and see what falls out.


jeff

Reply via email to