On Fri, Oct 30, 2015 at 2:11 PM, Richard Sandiford <richard.sandif...@arm.com> wrote: > Is the split_block change really so bad?
IMHO: Yes. split_block just splits some basic block B into two blocks B1/B2 somewhere in the middle of B. The dominance relations between B1 and B2 are obvious and intuitive. The new flag to split_block is not. The dominance info is not updated but the loops are? Confusing, if you ask me... Your situation, where a pass knows the dominance relations will change, is unusual. The extra work to fix up the ET tree twice should be negligible anyway. Ciao! Steven
