On Wed, Nov 18, 2015 at 05:24:34PM +0100, Bernd Schmidt wrote:
> That seems to change the behaviour of the code though. Most of the code in
> warn_tautological_cmp only looks at the unfolded form. Are you sure this is
> safe, for example wrt. the from_macro_expansion_at tests or the
> CONVERT_EXPR_P ones?
Of course the second version is wrong wrt CONVERT_EXPR_P, because it would
regress g++.dg/warn/Wtautological-compare.C -- with the fold() in the C++
FE we'd get rid of the CONVERT_EXPR_P completely and we'd warn.
Sorry :(. So I guess scratch the second version and let's get back to the
first one. Jason's r230471 was a correct thing to do.
Marek
