On 12/04/2015 08:36 PM, Jakub Jelinek wrote:
On Fri, Dec 04, 2015 at 06:19:19PM +0000, Manuel López-Ibáñez wrote:
My guess is that the first error_at should use arg instead of
option->opt_text to be equivalent. Of course, ideally, this code would
not be duplicated, but rather merged "somehow".
Consider that fixed. As for duplication, as one operates on
cl_decoded_option and the other not etc., this is harder, plus
the missing and non-int cases are IMHO short enough that it is not worth
trying hard to avoid the duplication.
For the enum case which is larger, it is maybe worth adding
a helper routine for it, which would need probably only
location_t loc, const struct cl_enum *e, const char *opt, unsigned int lang_mask
arguments. Can try that on Monday.
Maybe you can split the error printing code out of read_cmdline_option.
For the original patch I noticed the duplication but figured it was not
enough to really worry about, but for the error handling I think we
should make an effort.
Bernd
