On 01/26/2016 03:32 PM, Jakub Jelinek wrote:
>+ if (CHECKING_P)
>+ verify_constructor_flags (t);
>+ else
>+ recompute_constructor_flags (t);
But I don't understand this. Either the flags are supposed to be already
correct here, then I'd expect to see
if (CHECKING_P)
verify_constructor_flags (t);
only, or they are not guaranteed to be correct, and then I'd expect
unconditional
recompute_constructor_flags (t).
They are supposed to be correct, so when --enable-checking, we check for
that. The recompute is for better fault-tolerance in release compilers
in case the patch doesn't catch everything.
Jason
