On Wed, Jan 27, 2016 at 4:33 PM, Jason Merrill <ja...@redhat.com> wrote: > On 01/25/2016 11:45 PM, Patrick Palka wrote: >> >> +/* This needs to be set to TRUE before the lexer-debugging infrastructure >> can >> + be used. The point of this flag is to help the compiler to fold away >> calls >> + to cp_lexer_debugging_p within this source file at compile time, when >> the >> + lexer is not being debugged. */ >> + >> +#define LEXER_DEBUGGING_ENABLED_P false > > > I wonder about using an existing flag, such as CHECKING_P, but I guess this > is OK too.
The way I look at it is that you need to deliberately add calls to cp_lexer_[start|stop]_debugging in parser.c in order to make use of the lexer debugging stuff anyway, so it's not too invasive to guard this functionality behind a distinct flag that needs to be manually toggled within parser.c. And it is nice to avoid this overhead even when CHECKING_P, to provide a minor speed-up in bootstrap times and stuff.
