On Wed, 2 Mar 2016, Tom de Vries wrote:

> On 01-03-16 10:45, Richard Biener wrote:
> > On Tue, 1 Mar 2016, Tom de Vries wrote:
> > 
> > > Hi,
> > > 
> > > this patch fixes graphite PR68659, which is a 6 regression.
> > > 
> > > The patch fixes two things:
> > > - by handling new_expr == NULL_TREE in collect_all_ssa_names, it handles a
> > >    COMPONENT_REF where operand 2 is NULL_TREE.
> > > - it handles an ADDR_EXPR in get_new_name.
> > > Together, they allow the currently failing test-case
> > > gcc.dg/graphite/id-pr45230-1.c to pass.
> > > 
> > > Bootstrapped and reg-tested on x86_64.
> > > 
> > > OK for stage4 trunk?
> > 
> > @@ -1804,6 +1806,9 @@ get_new_name (basic_block new_bb, tree op,
> >     if (is_constant (op))
> >       return op;
> > 
> > +  if (TREE_CODE (op) == ADDR_EXPR)
> > +    return op;
> > +
> >     return get_rename (new_bb, op, old_bb, phi_kind);
> >   }
> > 
> > 
> > please instead change the is_constant (op) condition to
> > TREE_CODE (op) != SSA_NAME.
> 
> Done.
> 
> Bootstrapped and reg-tested on x86_64.
> 
> OK for stage4 trunk?

Ok.

Richard.

Reply via email to