On 17/08/11 11:48, Ramana Radhakrishnan wrote: > On 17 August 2011 08:59, Richard Sandiford <richard.sandif...@linaro.org> > wrote: >> EABI functions like __aeabi_f2ulz are defined as aliases of standard >> libgcc functions like __fixunssfdi. In libgcc.a, the standard function >> gets the correct hidden visibility, but the alias retains default >> visibility. This means that DSOs linked against libgcc.a may end >> up exporting the libgcc.a definition of __aeabi_f2ulz. >> >> The bug is that bpabi-lib.h uses an asm statement to define an alias, >> so the standard ways of forcing hidden visibility at the C level have >> no effect. Fixed by using attributes instead. >> >> Tested on arm-linux-gnueabi. Also tested by making sure that libgcc.a >> defined no default-visibility symbols. OK for trunk? > > This is OK. > >> >> What about release branches? I suppose this isn't a regression, >> but it is a backwards-compatible ABI fix. > > I can't see why not. That's reason enough for me to consider the > backport but I'd like other maintainers to chime in. >
Ok, provided there are no objections from the branch maintainers. R.
