Hi,
I've run:
- the goacc.exp testcases, and
- the target-libgomp oacc testcases
with -Wuninitialized, and found a few missing initalizations. Fixed and
committed as attached.
Thanks,
- Tom
Add missing initializations in oacc testcases
2016-03-23 Tom de Vries <t...@codesourcery.com>
* c-c++-common/goacc/kernels-default.c (foo): Add missing
initialization.
* gfortran.dg/goacc/private-3.f95 (test): Same.
* gfortran.dg/goacc/routine-5.f90 (gang, worker, vector, seq): Add
missing use param.
* testsuite/libgomp.oacc-fortran/reduction-2.f90: Add missing
initialization of lresult and lvresult.
* testsuite/libgomp.oacc-fortran/reduction-3.f90: Same.
---
gcc/testsuite/c-c++-common/goacc/kernels-default.c | 2 +-
gcc/testsuite/gfortran.dg/goacc/private-3.f95 | 1 +
gcc/testsuite/gfortran.dg/goacc/routine-5.f90 | 4 ++++
libgomp/testsuite/libgomp.oacc-fortran/reduction-2.f90 | 4 ++--
libgomp/testsuite/libgomp.oacc-fortran/reduction-3.f90 | 4 ++--
5 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/gcc/testsuite/c-c++-common/goacc/kernels-default.c b/gcc/testsuite/c-c++-common/goacc/kernels-default.c
index 58cd5e1..cb031c1 100644
--- a/gcc/testsuite/c-c++-common/goacc/kernels-default.c
+++ b/gcc/testsuite/c-c++-common/goacc/kernels-default.c
@@ -4,7 +4,7 @@
void
foo (void)
{
- unsigned int i;
+ unsigned int i = 0;
#pragma acc kernels
{
i++;
diff --git a/gcc/testsuite/gfortran.dg/goacc/private-3.f95 b/gcc/testsuite/gfortran.dg/goacc/private-3.f95
index 3490263..a7c6d81 100644
--- a/gcc/testsuite/gfortran.dg/goacc/private-3.f95
+++ b/gcc/testsuite/gfortran.dg/goacc/private-3.f95
@@ -14,6 +14,7 @@ program test
! !$acc end parallel
!$acc parallel private (k)
+ k = 0
!$acc loop reduction (+:k)
do i = 1, n
k = k + 1
diff --git a/gcc/testsuite/gfortran.dg/goacc/routine-5.f90 b/gcc/testsuite/gfortran.dg/goacc/routine-5.f90
index 68c5149..5037a31 100644
--- a/gcc/testsuite/gfortran.dg/goacc/routine-5.f90
+++ b/gcc/testsuite/gfortran.dg/goacc/routine-5.f90
@@ -5,6 +5,7 @@ module param
end module param
subroutine gang (a)
+ use param
!$acc routine gang
integer, intent (inout) :: a(N)
integer :: i
@@ -31,6 +32,7 @@ subroutine gang (a)
end subroutine gang
subroutine worker (a)
+ use param
!$acc routine worker
integer, intent (inout) :: a(N)
integer :: i
@@ -57,6 +59,7 @@ subroutine worker (a)
end subroutine worker
subroutine vector (a)
+ use param
!$acc routine vector
integer, intent (inout) :: a(N)
integer :: i
@@ -83,6 +86,7 @@ subroutine vector (a)
end subroutine vector
subroutine seq (a)
+ use param
!$acc routine seq
integer, intent (inout) :: a(N)
integer :: i
diff --git a/libgomp/testsuite/libgomp.oacc-fortran/reduction-2.f90 b/libgomp/testsuite/libgomp.oacc-fortran/reduction-2.f90
index 3d99668..96955ce 100644
--- a/libgomp/testsuite/libgomp.oacc-fortran/reduction-2.f90
+++ b/libgomp/testsuite/libgomp.oacc-fortran/reduction-2.f90
@@ -92,8 +92,8 @@ program reduction_2
if (result.ne.vresult) call abort
- result = 1
- vresult = 1
+ lresult = .true.
+ lvresult = .true.
! '.and.' reductions
diff --git a/libgomp/testsuite/libgomp.oacc-fortran/reduction-3.f90 b/libgomp/testsuite/libgomp.oacc-fortran/reduction-3.f90
index d0b590e..ecf7fbe 100644
--- a/libgomp/testsuite/libgomp.oacc-fortran/reduction-3.f90
+++ b/libgomp/testsuite/libgomp.oacc-fortran/reduction-3.f90
@@ -92,8 +92,8 @@ program reduction_3
if (result.ne.vresult) call abort
- result = 1
- vresult = 1
+ lresult = .true.
+ lvresult = .true.
! '.and.' reductions
