On Tue, Apr 05, 2016 at 11:05:44AM +0200, Richard Biener wrote:
> True. By simple constant propagation I can remove a lot of code.
>
> I'm going to bootstrap / test the following - is this ok for trunk
> now (I'm going to write a better changelog).
LGTM with better Changelog, though I have small nits:
> - else if ((s_info->group_id == group_id)
> - && (s_info->cse_base == base))
> + if ((s_info->group_id == group_id)
> + && (s_info->cse_base == base))
+ if (s_info->group_id == group_id && s_info->cse_base == base)
instead, please.
> + if (store_info->group_id >= 0)
> + {
> + group_info *group
> = rtx_group_vec[store_info->group_id];
The formatting looks wrong and
group_info *group = rtx_group_vec[store_info->group_id];
fits now on one line.
> @@ -3086,30 +2886,6 @@ scan_reads_nospill (insn_info_t insn_inf
Please also rename the
dse_step2_nospill
scan_stores_nospill
scan_reads_nospill
dse_step5_nospill
functions to s/_nospill//g and adjust all their uses (and perhaps function
comments).
Jakub
